[UR] [L0 v2] Enable wait lists and signal events for command buffer in L0 adapter v2 #18456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xewar313
force-pushed
the
enable-waitlist-and-signal-bare
branch
from
741adb4 to
5a2beb0
Compare
To clarify this, the functionality added in this PR of exposing wait and signal events also isn't exposed in SYCL yet. It's not only updating signal/wait events of commands that isn't exposed. |
igchor
reviewed
May 14, 2025
| @@ -232,6 +237,14 @@ ur_result_t urEventRelease(ur_event_handle_t hEvent) try { | |||
| ur_result_t urEventWait(uint32_t numEvents, | |||
| const ur_event_handle_t *phEventWaitList) try { | |||
| for (uint32_t i = 0; i < numEvents; ++i) { | |||
| if (!phEventWaitList[i]->getIsEventInUse()) { | |||
| // TODO: This is a workaround for the underlying inconsistency | |||
There was a problem hiding this comment.
Repeating comment from the original PR: can't we manually signal the events to put them in a proper state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncated PR #18442. The mutable signal event and wait list functionality has been removed, since it is not used by SYCL and does not seem to be working properly.